Added full KMP support for the Gradle Plugin #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
approved these changes
Nov 25, 2025
Collaborator
Jozott00
left a comment
Jozott00
left a comment
There was a problem hiding this comment.
Nice! Looks good to me.
Comment on lines
+86
to
+90
| if (protocApplied.get()) { | ||
| error("Illegal access to protoc extension during DefaultProtocExtension.init") | ||
| } | ||
|
|
||
| protocApplied.set(true) |
Collaborator
There was a problem hiding this comment.
I think this should be
if (protocApplied.getAndSet(true) { ... }
to make it actually thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Gradle Plugin
Problem Description
KMP support was working only for commonMain/Test sets
Solution
Add full KMP sources hierarchy support